Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPF] Add warning for empty labels #4454

Merged
merged 2 commits into from
Jul 21, 2020
Merged

[WPF] Add warning for empty labels #4454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b15e6d
Add warning for empty label in required input
almedina-ms Jul 21, 2020
eca1218
Merge branch 'feature/inputEvolution' into user/almedina-ms/WPF_AddWa…
shalinijoshi19 Jul 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions source/dotnet/Library/AdaptiveCards.Rendering.Wpf/AdaptiveContainerRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,10 @@ public static FrameworkElement EncloseElementInPanel(AdaptiveRenderContext conte
panel.Children.Add(RenderLabel(context, inputElement, elementForAccessibility));
AddSpacing(context, context.Config.Inputs.Label.InputSpacing, panel);
}
else if (inputElement.IsRequired)
{
context.Warnings.Add(new AdaptiveWarning((int)AdaptiveWarning.WarningStatusCode.EmptyLabelInRequiredInput, "Input is required but there's no label for required hint rendering"));
}

panel.Children.Add(enclosingElement);
enclosingElement = panel;
Expand Down
2 changes: 1 addition & 1 deletion source/dotnet/Library/AdaptiveCards/AdaptiveWarning.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ namespace AdaptiveCards
public class AdaptiveWarning
{
// TODO #2749: temporary warning code for fallback card. Remove when common set of error codes created and integrated.
public enum WarningStatusCode { UnsupportedSchemaVersion = 7, InvalidLanguage = 12, MaxActionsExceeded = 13 };
public enum WarningStatusCode { UnsupportedSchemaVersion = 7, InvalidLanguage = 12, MaxActionsExceeded = 13, EmptyLabelInRequiredInput = 14 };

public AdaptiveWarning(int code, string message)
{
Expand Down