User/almedina ms/phantom of the xamarin back to the future #3766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update Web Chat hostconfig & designer css * formatting fix for .json file
* [UWP][TestApp] Usability Improvements * PR Feedback
* [UWP] Update test projects to use new locations * [Samples] Sort the files under samples/Tests by version * [UWP] Update test files to reflect new locations * Fix .NET * ios update * Update datauri test files
* Add pixel widths to column * Describe the pixel format of minHeight * Update 1.2.0 schema descriptions There's no actual schema validation changes, just description changes, so no need to bump the version number
Added tooling so that we can generate specs from our schema, so that our spec'ing process starts with updating the schema first, leading to less errors and mistakes in the end :) In `schemas\src`, add your new properties/elements to the schema  ### 3. Generate the updated spec If you followed the setup instructions, simply save the file and the spec will be updated! Add any necessary rendering details to the spec.  ## Review spec Submit a pull request for your updated spec/schema. The proposed schema in the proposal becomes outdated and should be replaced with a link to the PR.  I'll share more details about this at Monday's meeting. Lots of details about the new proposed spec'ing process are captured here: https://github.com/microsoft/AdaptiveCards/wiki/Project-Management ###### Microsoft Reviewers: [Open in CodeFlow](http://wpcp.azurewebsites.net/CodeFlowProtocolProxy2.php?pullrequest=https://github.com/microsoft/AdaptiveCards/pull/3068)
* Fix sidebar scrolling * Try/catch only the AC stuff
* Include version numbers on website's JS scripts * Fix root-relative path * Fix formatting
* Include version numbers on website's JS scripts * Fix root-relative path * Fix formatting * Version CSS files too
* added adaptive cards fabric; added tests * updated build scripts * input validation * reverted unintended changes * moved jest config to package.json; moved tests into src directory * CR feedback. updated string parsing; updated number parsing * updated snapshots; minor cleanups
…t type (#3109) * [Shared Model] Allow images in image set to not specify element type * [.NET] Allow images in image set to not specify element type * Fix spacing
* refactored fabric extension interface * added a readme * cleaning up fabric file names and package output structure * API polish, minor renames, webpack tweaks, example page * Made folders lowercase, matches the conventions in the rest of the repo * Renamed `usedFabricComponents` to `useFabricControls` * Changed README function call to `ACFabric.useFabricControls()` since it makes the use consistent when using either Browser/ESM usage. Devs who prefer to import just the function can do so if they choose * Added minified version with `npm run release` * Added example page that loads nicely! * renamed back to `useFabricComponents` after more research Fabric is still not externalized in webpack since I can't get the reference right. Will keep looking * bring fabric back into buncle * added styling to sample page * add gif to readme, make fabric external, update peer dependency version
* [JS] Hotfix bleed regression in ColumnSet * cleaning up sample payloads, fixing some site bugs * site fixes, sample updates, and designer package fixes * remove unused files * fix script
…dImage (#3116) * Add Deserialize from string method to Background image * Fix formatting * Fix extra initializer * Remove extra qualification
* Update tests * Update test resukts
[UWP] Fix null dereference in Media code path
…ue with WholeItemsPanel (#3710)
* updated the doc * Updated specs * updated the description * Updated specs * updated the doc to correct wrong info * Updated specs
1. Including PreRequisite section around repo bootstrap linking to root readme 2. Cleaning up build commands to use lerna to be consistent with root readme and removing redundant steps
Co-authored-by: shalinijoshi19 <[email protected]>
* [UWP] Remove image comparison from unit tests * Code review feedback
* Added MaxActions limit check and replaced multiple of GetActions() call That returns a structure by value * added UnitTesting and Warning * added UnitTesting and Warning fixed comments Co-authored-by: almedina-ms <[email protected]> Co-authored-by: shalinijoshi19 <[email protected]>
* updating telephony detection for markdown link * undo uneccesary changes * updated RichTextBlockRenderer to detect Telephony link * updated sample card Co-authored-by: shalinijoshi19 <[email protected]>
* Fix scrolling behaviour in multiline text input * Add test files Co-authored-by: shalinijoshi19 <[email protected]>
* [SharedModel] Skip date/time tests outside of Pacific TZ Fixes #3609 * Rename TEST_MODULE_INITIALIZE method * Remove TEST_MODULE_INITIALIZE altogether * Update macro name Co-authored-by: shalinijoshi19 <[email protected]>
New HostConfig for Cortana Windows UWP beta, light mode. To be added to the drop down as: Cortana (Beta) - Light
Co-authored-by: Matt Hidinger <[email protected]>
* Fix to have short time format * Change helper function * Add unit tets * Add sample test json * Remove unnecessary test file
* Updated Cover FillMode Behavior * Revew Comments Addresssed * adding testing card * Updated file
* Updated preprocessed text handling * updated formatting * Added Accesibility Tags * updated accessibility Co-authored-by: shalinijoshi19 <[email protected]>
* Updated iOS layout * removed wrapper on TextBlock and RichTextBlock renderers * updated layout views to use intrinsic contentsize * updated property value for layout vies * Added key value observation for hidden property to allow toggle visibility and the new layout change to work together * Updated views with toggle visibility to update its contentsize based on their visibility changes Updated padding priority for bleeding * restores to working project file * updated project file for xcode * updated for CR comments * Fixed for CR comments Co-authored-by: shalinijoshi19 <[email protected]>
Co-authored-by: shalinijoshi19 <[email protected]>
|
Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes |
almedina-ms
deleted the
user/almedina-ms/PhantomOfTheXamarinBackToTheFuture
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just the merge of master to the Xamarin.Forms branch
Microsoft Reviewers: Open in CodeFlow