Introduce version range checking #2199
Conversation
| Max // must always be last | ||
| }; | ||
|
|
||
| // Indicates if a SemanticVersion instance supports wildcards. We could use a bool here, but it complicates the |
There was a problem hiding this comment.
Indicates if a SemanticVersion instance supports wildcards [](start = 7, length = 58)
In what scenarios do we support wildcards vs not supporting them?
There was a problem hiding this comment.
wildcards are allowed in "requires" statements, but not as a version specification in a card
In reply to: 244860482 [](ancestors = 244860482)
| Max // must always be last | ||
| }; | ||
|
|
||
| // Indicates if a SemanticVersion instance supports wildcards. We could use a bool here, but it complicates the |
There was a problem hiding this comment.
complicates [](start = 100, length = 11)
For my own information, what's the complication?
There was a problem hiding this comment.
vacation's a bear -- I can't speak to this as cogently as I could've a month ago :)
IIRC, it had something to do with implicit bool casts for overloaded ctors:
class MyClass
{
public:
MyClass(bool doThing) { std::cout << "bool ctor\n"; }
MyClass(const std::string& inputString) { std::cout << "string ctor\n"; }
};
int main()
{
auto instance = MyClass("whee!");
}
which yields the surprising result:
> bool ctor
In reply to: 244860827 [](ancestors = 244860827)
| { | ||
| return false; | ||
| } | ||
| else if (lhsVersion == rhsVersion) |
There was a problem hiding this comment.
lhsVersion == rhsVersion [](start = 21, length = 24)
Make this a != and remove the empty clause?
|
This work, sadly, is now moot after a spec change. |
Part of work needed for #2019 in shared model -- introduce version range/wildcard support a la NuGet.