Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UWP][InputValidation] Required input with no label has no visual required indicator #4356

Closed
RebeccaAnne opened this issue Jul 10, 2020 · 3 comments
Labels

Comments

@RebeccaAnne
Copy link
Contributor

Platform

What platform is your issue or question related to? (Delete other platforms).

  • UWP

Details

The below card (a simplified version of our Inputs.json card where the name field has been marked required) uses placeholders for labels. As a result there is no label to append the * indicator to and there is no indication that the input is required until after submit. Is this the desired behavior?

image image
{
  "type": "AdaptiveCard",
  "version": "1.0",
  "body": [
    {
      "type": "TextBlock",
      "size": "medium",
      "text": "Please enter the following information:"
    },
    {
      "type": "Input.Text",
      "placeholder": "Name",
      "isRequired": true,
      "id" : "name",
      "errorMessage":"Name is required"
    },
    {
      "type": "Input.Text",
      "placeholder": "Homepage",
      "id": "homepage"
    },
    {
      "type": "Input.Text",
      "placeholder": "Email",
      "id": "EmailVal"
    },
    {
      "type": "Input.Text",
      "placeholder": "Phone",
      "id": "TelVal"
    }
  ],
  "actions": [
    {
      "type": "Action.Submit",
      "title": "Submit"
    }
  ]
}
@ghost ghost added the Triage-Needed label Jul 10, 2020
@RebeccaAnne RebeccaAnne changed the title [UWP][InputValidation] Required input with no label has no visual indicator [UWP][InputValidation] Required input with no label has no visual required indicator Jul 10, 2020
@ghost ghost removed the Triage-Needed label Jul 10, 2020
@ghost
Copy link

ghost commented Jul 10, 2020

Hi @RebeccaAnne. We have acknowledged this issue report. Please continue to follow this issue for updates/progress/questions.

@jwoo-msft
Copy link
Member

we are not going to block the shipping but we should look back at it.

@RebeccaAnne RebeccaAnne added SpecBug and removed Spec labels Jul 11, 2020
@RebeccaAnne
Copy link
Contributor Author

We've decided that this is the expected behavior. Using placeholders as labels is not a good practice in general, and card authors should use a label when marking inputs required. We will return warnings when a card author marks an input as required without including a label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants