Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for displaying Details List sort arrows on multiple columns #3875

Merged

Conversation

jblueml
Copy link
Contributor

@jblueml jblueml commented Jul 22, 2024

This should fix #3839.

As sorting by the user is only possible for one column at a time, a sort arrow is only displayed in the column according to which the search result is currently sorted.

@wobba
Copy link
Collaborator

wobba commented Jul 23, 2024

Thank you 🙂

@wobba wobba merged commit 507dbe0 into microsoft-search:develop Jul 23, 2024
@jblueml jblueml deleted the jblueml-fix-details-list-sort branch July 23, 2024 14:11
@corriespondent
Copy link

Thank you @jblueml!

@kasperbolarsen
Copy link
Collaborator

Testing just now, and it is awesome :-)

@kasperbolarsen
Copy link
Collaborator

in this case the results are sorted by Title (asc) as per the config but it does show. Would it be possible to show the initial sort as well ?

image

image

@jblueml
Copy link
Contributor Author

jblueml commented Sep 25, 2024

@kasperbolarsen:
Hmmm... That could be very tricky...

The problem is that columns could be marked as “not sortable” in the column configuration of the details list but in the sort settings of the search result the same columns are used for default-sorting.

If, for example, the “Title” column in your example is NOT set as sortable in the column settings of the details list, no arrow would be displayed, although the default sorting of the search result is “ascending by title”.

In addition, the details list can only be sorted by the user only by one column at a time.
However, more than one column can be set in the default sorting settings of the search result. Therefore, sorting by more than one column cannot be displayed in the details list.

Do you know what I mean?

@kasperbolarsen
Copy link
Collaborator

Yeah, that looks like a hard nut to crack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants