Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parseFloat to Number #3188

Merged
merged 1 commit into from
Aug 11, 2023
Merged

parseFloat to Number #3188

merged 1 commit into from
Aug 11, 2023

Conversation

0o001
Copy link
Contributor

@0o001 0o001 commented Aug 11, 2023

#3187

In my solution, I noticed that the parseFloat part could return incorrect values, and I reorganized it as follows:

parseFloat("1s"); //output: 1
parseFloat("1hello"); //output: 1

Number("1s") //output: NaN
Number("1hello"); //output: NaN

I'm sorry for this, it slipped my mind.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wobba wobba merged commit 2081d56 into microsoft-search:develop Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants