Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mapping spring RequestPart annotation to micronaut Part annotation #525

Merged
merged 2 commits into from
Feb 18, 2024

Conversation

altro3
Copy link
Contributor

@altro3 altro3 commented Jan 18, 2024

Fixed #376

@altro3
Copy link
Contributor Author

altro3 commented Jan 18, 2024

@graemerocher Don't know how to write correct mapper for org.springframework.web.multipart.MultipartFile argument. for full support @RequestPart annotation. Could anyone help?

@graemerocher
Copy link
Contributor

using org.springframework.web.multipart.MultipartFile would require a custom request argument binder probably

@altro3
Copy link
Contributor Author

altro3 commented Jan 26, 2024

@graemerocher Yeah, I understand, that a custom mapper (bender) is needed, but I do not understand how to write such a bender correctly, because I did not find such mappers for example, so I ask for help.

Once again, I want to draw your attention to the importance of this library. In my opinion, it comes in second place in importance after the core. I don't understand why you stopped developing it. If Microsoft could be used with spring, in my opinion, it would increase the popularity of the micronaut several times.

@graemerocher
Copy link
Contributor

because ultimately it is just a compatibility layer but full compatibility is not really achievable

@altro3
Copy link
Contributor Author

altro3 commented Jan 26, 2024

I agree, but now even basic compatibility doesn't work

@graemerocher
Copy link
Contributor

What doesn't work specifically?

@altro3
Copy link
Contributor Author

altro3 commented Jan 27, 2024

look to this: #521

@CLAassistant
Copy link

CLAassistant commented Feb 7, 2024

CLA assistant check
All committers have signed the CLA.

@altro3
Copy link
Contributor Author

altro3 commented Feb 17, 2024

@graemerocher I looked at everything again. It is quite difficult to make the correct mapping for the MultipartFile interface because its standard implementation is hidden and has private access.

So, I think that the basic mapping (which I did in this PR) is quite enough. We can merge it

@graemerocher graemerocher added the type: enhancement New feature or request label Feb 18, 2024
@graemerocher graemerocher merged commit 638fc11 into micronaut-projects:master Feb 18, 2024
6 checks passed
@graemerocher
Copy link
Contributor

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support "multipart/form-data" requests in spring rest controller
3 participants