Fixed gradle scripts. #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdelamo
requested changes
Jan 30, 2024
Fixed dependencies. Removed extra libraries from versions catalog. Upgrade libs.
|
@sdelamo done |
sdelamo
reviewed
Jan 31, 2024
| implementation mn.micronaut.runtime | ||
| implementation(mnCache.micronaut.cache.core) |
There was a problem hiding this comment.
In general, I would prefer not to remove the parenthesis. They are valid in both Groovy and Kotlin DSL.
There was a problem hiding this comment.
I agree that you can write parentheses everywhere. But I just brought the file to one view, because all the dependencies were without brackets, except this one.
test-suite/src/test/groovy/io/micronaut/spring/tx/MetaTransactionalBean.java
Show resolved
Hide resolved
test-suite/src/test/groovy/io/micronaut/spring/tx/TransactionalBean.java
Show resolved
Hide resolved
Fixed dependencies. Removed extra libraries from versions catalog. Upgrade libs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed dependencies.
Removed extra libraries from versions catalog.
Upgrade libs.