Support MessageBodyReader/Writer abstraction in Servlet #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graemerocher
commented
May 27, 2024
| // could fill out the response! Blocking here will ensure that the response is filled out | ||
| // before the main response publisher completes. This will be improved later to avoid the block. | ||
| Flux.from(responseEncoder.encode(exchange, routeAnnotationMetadata, body)).blockLast(); | ||
| if (body != null && !isVoid) { |
There was a problem hiding this comment.
this fixes a bug where void responses were still encoded to JSON
graemerocher
commented
May 27, 2024
| final MediaType mediaType = new MediaType(v[0]); | ||
| contentType(mediaType); | ||
| return mediaType; | ||
| if (body instanceof HttpResponseProvider responseProvider) { |
There was a problem hiding this comment.
this prevents the body being set to itself (problem in JAX-RS implementation)
yawkat
approved these changes
May 27, 2024
| final Publisher<T> publisher = Publishers.just(content); | ||
| final T converted = conversionService.convertRequired(publisher, type); | ||
| return () -> Optional.of(converted); | ||
| if (name == null && messageBodyReader != null && messageBodyReader.isReadable(context.getArgument(), mediaType)) { |
There was a problem hiding this comment.
i dont like how this logic is duplicated in core and here but i think it will have to wait until i come up with a response byte body api
graemerocher
force-pushed
the
message-body-writers2
branch
from
2bf8a23 to
a165b36
Compare
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Servlet doesn't currently support the message body writer/reader abstraction. This fixes that.