Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make disabling async a valid option not just for testing #700

Merged
merged 1 commit into from
May 22, 2024
Merged

Make disabling async a valid option not just for testing #700

merged 1 commit into from
May 22, 2024

Conversation

graemerocher
Copy link
Contributor

@graemerocher graemerocher commented May 22, 2024 •
edited
Loading

For virtual threads you don't really need async enabled. This adds an option to disable it.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@graemerocher graemerocher requested a review from yawkat May 22, 2024 10:59
@graemerocher graemerocher added the type: improvement A minor improvement to an existing feature label May 22, 2024
@graemerocher graemerocher merged commit 9135e6e into 4.8.x May 22, 2024
15 checks passed
@graemerocher graemerocher deleted the allow-disabling-async branch May 22, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yawkat yawkat yawkat approved these changes

Assignees
No one assigned
Labels
type: improvement A minor improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graemerocher @yawkat