Add binary-configuration to servlet-core #504
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class was used in both AWS and Azure, so we have pulled it up into servlet-core
|
SonarCloud Quality Gate failed.
|
|
I think more about this I think we should do this in core and it should be probably configurable. For example: A user may want to set:
to add extra types to the list we provide by default. |
timyates
added a commit
to micronaut-projects/micronaut-core
that referenced
this pull request
Jun 30, 2023
This is used by the AWS and Azure modules. Originally we moved this duplication to Servlet-core: micronaut-projects/micronaut-servlet#504 But it was then decided that core was a better home for it. It specified defaults, and allows users to ignore these defaults, and add their own mime types.
|
Superseded by micronaut-projects/micronaut-core#9530 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class was used in both AWS and Azure, so we have pulled it up into servlet-core