Handle HttpStatusException encoding a response #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HttpStatusException was handled as an internal server error. This showed itself in the StreamTest TCK test for AWS (which calls a reactive endpoint on a synchronous connection)
|
This PR also handles Undertow flakiness. Undertow asynchronously marks the OutputStream as being In StreamTest, we throw the error quickly and the undertow has not yet set this up in an async task. This means that for Undertow, the status is ok, but the body of the response is sometimes missing. I added checks to make sure we don't write to an unready outputstream (as this will throw different errors, and mask the underlying status exception) |
|
SonarCloud Quality Gate failed. |
sdelamo
approved these changes
Jun 14, 2023
yawkat
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpStatusException was handled as an internal server error.
This showed itself in the StreamTest TCK test for AWS (which calls a reactive endpoint on a synchronous connection)
When this is released, this will fix the StreamTest TCK in the AWS module