Servlet Merge up 3.4.x into master #474
Merged
+340
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix Servlet binding for Publisher types Backport of #373 to 3.3.x * No Graal 11 dev anymore * Fix * Add token
Backports fixes added in #364
* test: HTTP Server TCK for tomcat, jetty and undertow * apply new HTTP Server TCK * ci: projectVersion 3.5.0-SNAPSHOT [ci skip] * ci: githubCoreBranch 3.9.x [ci skip] * bump up Micronaut Gradle Plugin to 3.6.7 * simplify build * compatibility with Java 8 * build: update to MN 3.8.0 * build: update to MN Test 3.8.0 * test: update SSL tests Backports fixes added in #364 * source compatibility 1.8 * exclude RemoteAddressTest test is failing with: org.opentest4j.AssertionFailedError: expected: <127.0.0.1> but was: <10.1.0.227>
Previously, the servlet container was bound to all interfaces on 0.0.0.0 This change switches to bind to localhost by default as we dso with the Netty server. It's a breaking change for security reasons, so I have raised it against 3.3.x.
# Conflicts: # .github/workflows/graalvm.yml # gradle.properties # settings.gradle
On OSX, the temp folder path is /var/folders/.... However, the real (canonical) path is /private/var/folders... That's why this test failed on OS X but passed on CI
Fix Servlet request for when context path is configured
sdelamo
commented
Jun 6, 2023
| @@ -45,6 +46,7 @@ class JettyCorsSpec extends Specification implements TestPropertyProvider { | |||
| headerNames.contains(SERVER) | |||
| } | |||
|
|
|||
| @PendingFeature | |||
There was a problem hiding this comment.
@timyates can you investigate why this test fails?
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.