Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the TCK tests to pass #432

Merged
merged 3 commits into from
Apr 27, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
package io.micronaut.http.server.tck.jetty.tests;

import io.micronaut.context.annotation.Replaces;
import io.micronaut.context.annotation.Requires;
import io.micronaut.core.annotation.NonNull;
import io.micronaut.http.HttpRequest;
import io.micronaut.http.server.util.HttpHostResolver;
import jakarta.inject.Singleton;

@Singleton
@Requires(property = "spec.name", value = "CorsSimpleRequestTest")
@Replaces(HttpHostResolver.class)
public class HttpHostResolverReplacement implements HttpHostResolver {

@Override
@NonNull
public String resolve(HttpRequest request) {
return "http://localhost:8080";
}
}
Original file line number Diff line number Diff line change
@@ -9,11 +9,8 @@
@SelectPackages("io.micronaut.http.server.tck.tests")
@SuiteDisplayName("HTTP Server TCK for Jetty")
@ExcludeClassNamePatterns({
"io.micronaut.http.server.tck.tests.cors.CorsSimpleRequestTest",
"io.micronaut.http.server.tck.tests.staticresources.StaticResourceTest", // fails on GraalVm
"io.micronaut.http.server.tck.tests.filter.ClientResponseFilterTest", // fails on GraalVM
"io.micronaut.http.server.tck.tests.ErrorHandlerTest" // fails on GraalVM

"io.micronaut.http.server.tck.tests.staticresources.StaticResourceTest", // Graal fails to see /assets from the TCK as a resource https://ge.micronaut.io/s/ufuhtbe5sgmxi
"io.micronaut.http.server.tck.tests.filter.ClientResponseFilterTest", // responseFilterThrowableParameter fails under Graal https://ge.micronaut.io/s/ufuhtbe5sgmxi
})
public class JettyHttpServerTestSuite {
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
package io.micronaut.http.server.tck.tomcat.tests;

import io.micronaut.context.annotation.Replaces;
import io.micronaut.context.annotation.Requires;
import io.micronaut.core.annotation.NonNull;
import io.micronaut.http.HttpRequest;
import io.micronaut.http.server.util.HttpHostResolver;
import jakarta.inject.Singleton;

@Singleton
@Requires(property = "spec.name", value = "CorsSimpleRequestTest")
@Replaces(HttpHostResolver.class)
public class HttpHostResolverReplacement implements HttpHostResolver {

@Override
@NonNull
public String resolve(HttpRequest request) {
return "http://localhost:8080";
}
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package io.micronaut.http.server.tck.tomcat.tests;

import org.junit.platform.suite.api.ExcludeClassNamePatterns;
import org.junit.platform.suite.api.IncludeClassNamePatterns;
import org.junit.platform.suite.api.SelectPackages;
import org.junit.platform.suite.api.Suite;
import org.junit.platform.suite.api.SuiteDisplayName;
@@ -10,10 +9,8 @@
@SelectPackages("io.micronaut.http.server.tck.tests")
@SuiteDisplayName("HTTP Server TCK for Tomcat")
@ExcludeClassNamePatterns({
"io.micronaut.http.server.tck.tests.cors.CorsSimpleRequestTest",
"io.micronaut.http.server.tck.tests.staticresources.StaticResourceTest", // fails on GraalVm
"io.micronaut.http.server.tck.tests.filter.ClientResponseFilterTest", // fails on GraalVM
"io.micronaut.http.server.tck.tests.ErrorHandlerTest" // fails on GraalVM
"io.micronaut.http.server.tck.tests.staticresources.StaticResourceTest", // Graal fails to see /assets from the TCK as a resource https://ge.micronaut.io/s/ufuhtbe5sgmxi
"io.micronaut.http.server.tck.tests.filter.ClientResponseFilterTest", // responseFilterThrowableParameter fails under Graal https://ge.micronaut.io/s/ufuhtbe5sgmxi
})
public class TomcatHttpServerTestSuite {
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
package io.micronaut.http.server.tck.undertow.tests;

import io.micronaut.context.annotation.Replaces;
import io.micronaut.context.annotation.Requires;
import io.micronaut.core.annotation.NonNull;
import io.micronaut.http.HttpRequest;
import io.micronaut.http.server.util.HttpHostResolver;
import jakarta.inject.Singleton;

@Singleton
@Requires(property = "spec.name", value = "CorsSimpleRequestTest")
@Replaces(HttpHostResolver.class)
public class HttpHostResolverReplacement implements HttpHostResolver {

@Override
@NonNull
public String resolve(HttpRequest request) {
return "http://localhost:8080";
}
}
Original file line number Diff line number Diff line change
@@ -9,11 +9,9 @@
@SelectPackages("io.micronaut.http.server.tck.tests")
@SuiteDisplayName("HTTP Server TCK for Undertow")
@ExcludeClassNamePatterns({
"io.micronaut.http.server.tck.tests.cors.CorsSimpleRequestTest",
"io.micronaut.http.server.tck.tests.RemoteAddressTest",
"io.micronaut.http.server.tck.tests.staticresources.StaticResourceTest", // fails on GraalVm
"io.micronaut.http.server.tck.tests.filter.ClientResponseFilterTest", // fails on GraalVM
"io.micronaut.http.server.tck.tests.ErrorHandlerTest" // fails on GraalVM
"io.micronaut.http.server.tck.tests.RemoteAddressTest", // Undertow.getHost() reports an ipv6 address, not 127.0.0.1
"io.micronaut.http.server.tck.tests.staticresources.StaticResourceTest", // Graal fails to see /assets from the TCK as a resource https://ge.micronaut.io/s/ufuhtbe5sgmxi
"io.micronaut.http.server.tck.tests.filter.ClientResponseFilterTest", // responseFilterThrowableParameter fails under Graal https://ge.micronaut.io/s/ufuhtbe5sgmxi
})
public class UndertowHttpServerTestSuite {
}