Use core M2

[timyates]

Fix up removed and deprecated methods

[timyates]

@graemerocher Is this the correct replacement?

[timyates]

Seems not (or something else has changed) as now this is failing

micronaut-servlet/http-server-jetty/src/test/groovy/io/micronaut/servlet/jetty/JettyExceptionHandlerSpec.groovy

Lines 44 to 52 in f23fc5d

	void "test an exception handler returning the body"() {
	when:
	client.toBlocking().retrieve("/exception/my")
	then:
	def ex = thrown(HttpClientResponseException)
	ex.response.status() == HttpStatus.INTERNAL_SERVER_ERROR
	ex.response.getBody().get() == "hello"
	}

[dstepanov]

Looks correct

[timyates]

@dstepanov There's also route.getRouteInfo().getBodyArgument()... What's the difference?

[timyates]

So it seems the issue with the failing test:

micronaut-servlet/http-server-jetty/src/test/groovy/io/micronaut/servlet/jetty/JettyExceptionHandlerSpec.groovy

Lines 44 to 52 in f23fc5d

	void "test an exception handler returning the body"() {
	when:
	client.toBlocking().retrieve("/exception/my")
	then:
	def ex = thrown(HttpClientResponseException)
	ex.response.status() == HttpStatus.INTERNAL_SERVER_ERROR
	ex.response.getBody().get() == "hello"
	}

Is that when we execute normalFlow() for the request lifecycle here

micronaut-servlet/servlet-core/src/main/java/io/micronaut/servlet/http/ServletHttpHandler.java

Lines 207 to 211 in a79b1c1

	lc.handleNormal()
	.onComplete((response, throwable) -> onComplete(exchange, req, response, throwable, httpResponse -> {
	asyncExecution.complete();
	requestTerminated.accept(httpResponse);
	}));

We're getting a 200 response (with the expected body) wheras prior to core-M2, we got a 500

@dstepanov Can you spot what I've missed? I'm assuming there's something new I need to set up in the RequestLifecycle?

[dstepanov]

@timyates To me, the test doesn't look correct. The exception is remapped so there shouldn't be any error. Maybe we can add that test to TCK?

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication