Add shared, lazy SessionKeySupplier implementation #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
|
❌ Oracle Cloud CI 17 latest failed: https://ge.micronaut.io/s/dt3ubadg6sxqc |
During startup, prof shows that a significant time is spent inside RSA key generation in the default SessionKeySupplierImpl, both in the constructor and in refreshKeys. This PR adds a new implementation that avoids generating keys until first time of use, and shares the session key between authorization providers. Sharing between bootstrap and normal context is not yet implemented. I have no way to test this, so can't say how much it helps.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* fix(deps): update dependency org.apache.groovy:groovy-bom to v4.0.22 * Update common files --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Chaimaa Rouai <[email protected]>
renovate
bot
force-pushed
the
renovate/actions-github-script-7.x
branch
from
124b667 to
519630f
Compare
|
sdelamo
approved these changes
Aug 21, 2024
| @@ -77,6 +78,10 @@ public class OracleCloudCoreFactory { | |||
|
|
|||
| private OracleCloudConfigFileConfigurationProperties ociConfigFileConfiguration; | |||
|
|
|||
| @Inject | |||
| @Nullable | |||
| SessionKeySupplier sessionKeySupplier; | |||
There was a problem hiding this comment.
why not use constructor injection instead?
sdelamo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v6->v7Release Notes
actions/github-script (actions/github-script)
v7Compare Source
Configuration
📅 Schedule: Branch creation - "after 10pm" in timezone Europe/Prague, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.