OracleCloud MeterRegistry with raw data #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n0tl3ss
changed the title
graemerocher
approved these changes
Jan 26, 2024
burtbeckwith
requested changes
Jan 26, 2024
...in/java/io/micronaut/oraclecloud/monitoring/micrometer/AbstractOracleCloudMeterRegistry.java
Outdated
Show resolved
Hide resolved
...in/java/io/micronaut/oraclecloud/monitoring/micrometer/AbstractOracleCloudMeterRegistry.java
Outdated
Show resolved
Hide resolved
...in/java/io/micronaut/oraclecloud/monitoring/micrometer/AbstractOracleCloudMeterRegistry.java
Outdated
Show resolved
Hide resolved
...in/java/io/micronaut/oraclecloud/monitoring/micrometer/AbstractOracleCloudMeterRegistry.java
Show resolved
Hide resolved
...in/java/io/micronaut/oraclecloud/monitoring/micrometer/AbstractOracleCloudMeterRegistry.java
Outdated
Show resolved
Hide resolved
...icrometer/src/main/java/io/micronaut/oraclecloud/monitoring/primitives/OracleCloudTimer.java
Outdated
Show resolved
Hide resolved
...meter/src/main/java/io/micronaut/oraclecloud/monitoring/OracleCloudMeterRegistryFactory.java
Outdated
Show resolved
Hide resolved
...meter/src/main/java/io/micronaut/oraclecloud/monitoring/OracleCloudMeterRegistryFactory.java
Outdated
Show resolved
Hide resolved
...meter/src/main/java/io/micronaut/oraclecloud/monitoring/OracleCloudMeterRegistryFactory.java
Outdated
Show resolved
Hide resolved
...meter/src/main/java/io/micronaut/oraclecloud/monitoring/OracleCloudMeterRegistryFactory.java
Outdated
Show resolved
Hide resolved
…monitoring/micrometer/AbstractOracleCloudMeterRegistry.java Co-authored-by: Burt Beckwith <[email protected]>
Co-authored-by: Burt Beckwith <[email protected]>
Co-authored-by: Burt Beckwith <[email protected]>
burtbeckwith
approved these changes
Jan 26, 2024
|
|
❌ Oracle Cloud CI 17 latest failed: https://ge.micronaut.io/s/2g3eyqu4aynea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new OracleCloud Meter registry that will provide more accuracy to the metrics. The old OracleCloud meter registry aggregates all data and publishes it to OracleCloud. Because of aggregation of the metrics the server side doesn't make any sense for aggregation.
Raw metrics are available for:
CounterTimerDistributionSummaryOther primitives like
Gauge,FunctionCounter,FunctionTimerare only observed once before publishing metrics, so no raw data is available.