Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix discriminator override for kotlin #1887

Closed

Conversation

altro3
Copy link
Collaborator

@altro3 altro3 commented Nov 21, 2024

Fixed #1881

The same problem for kotlin generator.

Also minor improvements for generated kotlin code

@altro3 altro3 force-pushed the kotlin-discriminator-override branch from 50b4fb9 to 95bc64b Compare November 21, 2024 10:10
@altro3
Copy link
Collaborator Author

altro3 commented Nov 21, 2024

@sdelamo You're a bit hasty with the release, I fixed the problem with override in Java, but forgot about Kotlin.

In general, it would be desirable to merge this fix as well, because now the problem persists with the generator for Kotlin. Maybe release 6.13.3?

@altro3 altro3 force-pushed the kotlin-discriminator-override branch from 95bc64b to ede98e3 Compare November 21, 2024 13:11
@altro3
Copy link
Collaborator Author

altro3 commented Nov 23, 2024

@sdelamo ping

@matadini
Copy link

@altro3 @sdelamo

Hi
I'm asking here because I don't know where I could do this, so:
When do you plan to release a new version of the micronaut-gradle-plugin that will include fix #1881? After merging kotlin fix? Or do you have any particular roadmap?

I'm asking because it is important for me from the perspective of developing an application for a client.

@altro3
Copy link
Collaborator Author

altro3 commented Nov 25, 2024

@matadini You don't need to wait for a fix for Kotlin, the fix for Java is already merged and included in the 6.13.2 release.

To use the latest version of micronaut-openapi in the gradle plugin, just write this:

micronaut {
    openapi {
        version = "6.13.2"
        client(file("swagger.yml")) {
              ...
        }
    }
}

@altro3
Copy link
Collaborator Author

altro3 commented Nov 30, 2024

continue here: #1894

@altro3 altro3 closed this Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenAPI, invalid @Override annotation in base class, in inheritance case.
2 participants