Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added schema duplication resolution mode #1701

Conversation

altro3
Copy link
Collaborator

@altro3 altro3 commented Aug 17, 2024

Fixed #1698

Deprecated configuration properties:

micronaut.openapi.schema-prefix
micronaut.openapi.schema-postfix
micronaut.openapi.schema

New configuration properties to replace deprecated:

micronaut.openapi.schema.decorator.prefix
micronaut.openapi.schema.decorator.postfix
micronaut.openapi.schema.mapping

@altro3 altro3 requested a review from graemerocher August 17, 2024 11:31
@altro3 altro3 force-pushed the add-schema-duplication-resolution-mode branch from e1d8951 to 413523c Compare August 17, 2024 11:41
Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change, is not it? Users upgrading with configuration keys will have to update their config.

@altro3
Copy link
Collaborator Author

altro3 commented Aug 21, 2024

@sdelamo no. Now schemas with same name renamed with index, and after this improvement, default behaviour will be the same. But I add new mode error, if you want to fix schema duplication manually

@altro3
Copy link
Collaborator Author

altro3 commented Aug 21, 2024

Ah... you talking about other options... So the main problem with this property: micronaut.openapi.schema. Need to change it, but how we can do it?

@sdelamo
Copy link
Contributor

sdelamo commented Aug 21, 2024

Ah... you talking about other options... So the main problem with this property: micronaut.openapi.schema. Need to change it, but how we can do it?

We will have to add additional configuration options without creating a breaking change.

@altro3
Copy link
Collaborator Author

altro3 commented Aug 21, 2024

Ok, I'll fix it tomorrow

@altro3 altro3 force-pushed the add-schema-duplication-resolution-mode branch from 413523c to afdb9f5 Compare August 22, 2024 04:50
@altro3 altro3 force-pushed the add-schema-duplication-resolution-mode branch from afdb9f5 to 5b619b3 Compare August 22, 2024 04:50
@altro3
Copy link
Collaborator Author

altro3 commented Aug 22, 2024

@sdelamo fixed

@altro3 altro3 requested a review from sdelamo August 22, 2024 14:40
@sdelamo sdelamo merged commit 497c5ff into micronaut-projects:6.12.x Aug 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Generated spec contains only one Schema if multiple Schema.name="xy" exist
2 participants