Add support extra Schemas #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graemerocher
requested changes
Jul 1, 2024
openapi/src/main/java/io/micronaut/openapi/visitor/OpenApiExtraSchemaVisitor.java
Outdated
Show resolved
Hide resolved
| */ | ||
| @Internal | ||
| @SupportedOptions(MICRONAUT_OPENAPI_ENABLED) | ||
| public class OpenApiExtraSchemaVisitor implements TypeElementVisitor<Object, Object> { |
There was a problem hiding this comment.
override getVisitorKind and return ISOLATING since this processes just a single annotation
There was a problem hiding this comment.
if I set ISOLATING kind, it doesn't work
openapi/src/main/java/io/micronaut/openapi/visitor/OpenApiExtraSchemaVisitor.java
Outdated
Show resolved
Hide resolved
openapi/src/main/java/io/micronaut/openapi/visitor/OpenApiExtraSchemaVisitor.java
Outdated
Show resolved
Hide resolved
altro3
force-pushed
the
extra-schemas
branch
5 times, most recently
from
7518b61 to
2423d33
Compare
|
could you target the 6.12.x branch? |
graemerocher
requested changes
Jul 3, 2024
openapi/src/main/java/io/micronaut/openapi/visitor/OpenApiExtraSchemaVisitor.java
Outdated
Show resolved
Hide resolved
@graemerocher done |
graemerocher
approved these changes
Jul 3, 2024
|
Thanks for the contribution |
altro3
added a commit
to altro3/micronaut-openapi
that referenced
this pull request
Jul 9, 2024
Move schema definition logic to different class Fixed micronaut-projects#1598
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move schema definition logic to different class
Fixed #1598