Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue # 130 - Case 2 #132

Merged
merged 2 commits into from
Feb 6, 2020
Merged

Conversation

croudet
Copy link

@croudet croudet commented Feb 6, 2020

A parameter with no annotation is considered as a PathVariable.

#130

A parameter with no annotation is considered as a PathVariable.
@graemerocher
Copy link
Contributor

Maybe needs a test

@croudet
Copy link
Author

croudet commented Feb 6, 2020

Tests added.

@graemerocher graemerocher merged commit ef84c63 into micronaut-projects:master Feb 6, 2020
@graemerocher
Copy link
Contributor

Thanks 👍

@outersky
Copy link

outersky commented Feb 7, 2020

@croudet Default as a PathVariable but not a QueryValue ?

With my test project

the correct request is :

curl http://localhost:8080/find1?name=outersky

but now swagger-ui sends a request as :

curl -X GET "http://localhost:8080/find1" -H "accept: application/json"

which will lead to an error:

{
  "message": "Required argument [String name] not specified",
  "path": "/name",
  "_links": {
    "self": {
      "href": "/find1",
      "templated": false
    }
  }
}

@croudet croudet deleted the Isse130-Case2 branch February 11, 2020 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants