-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge 4.10 #1130
Merge 4.10 #1130
Conversation
altro3
commented
Jul 15, 2023
- Add support JsonView
- Add ability to set project directory manually
- Minor fixes in documentation
- Minor code cleanup
- Upgarde libs and gradle 8.2.1
Add support for @JSONVIEW
# Conflicts: # gradle/libs.versions.toml # openapi/src/main/java/io/micronaut/openapi/visitor/AbstractOpenApiEndpointVisitor.java # openapi/src/main/java/io/micronaut/openapi/visitor/AbstractOpenApiVisitor.java
# Conflicts: # gradle.properties # gradle/libs.versions.toml # src/main/docs/guide/swaggerAnnotations/schemasAndGenerics.adoc
…4.10 Add process WildcardElement and GenericPlaceholderElement (4.10)
Update libraries. Minor documentation fixes
# Conflicts: # openapi/src/main/java/io/micronaut/openapi/visitor/AbstractOpenApiVisitor.java
# Conflicts: # openapi/src/main/java/io/micronaut/openapi/visitor/AbstractOpenApiVisitor.java # openapi/src/test/groovy/io/micronaut/openapi/visitor/OpenApiSchemaGenericsSpec.groovy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, keep the configuration
macro.
gradle/libs.versions.toml
Outdated
managed-javadoc-parser = "0.3.1" | ||
managed-jsoup = "1.16.1" | ||
managed-html2md-converter = "0.64.8" | ||
|
||
kotlin = "1.8.22" | ||
kotlin = "1.9.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are not updating to Kotlin 1.9.0 yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -82,7 +83,7 @@ public class OrderController { | |||
|
|||
Do not forget to configure Micronaut Security accordingly: | |||
|
|||
[configuration] | |||
[source,yaml] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we want to use the configuration macro to output documentation not just in yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
To expose the `swagger-ui` views, you also must expose the generated `yaml`: | ||
|
||
.Exposing Swagger YAML and Swagger UI Views | ||
[configuration] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we want to use configuration
macro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -36,17 +36,17 @@ See https://github.com/Redocly/redoc#redoc-options-object[Redoc Options] for a d | |||
To expose the `redoc` views, you also must expose the generated `yaml`: | |||
|
|||
.Exposing Swagger YAML And Redoc Views | |||
[configuration] | |||
[source,yaml] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we want to use the configuration
macro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -52,17 +52,17 @@ See https://mrin9.github.io/RapiDoc/api.html[RapiDoc Options] for a description. | |||
To expose the `rapidoc` views, you also must expose the generated `yaml`: | |||
|
|||
.Exposing Swagger YAML And Rapidoc Views | |||
[configuration] | |||
[source,yaml] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we want to use the configuration
macro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -5,13 +5,13 @@ Thus, by default, the views expect to find the `yaml` under `/swagger`. | |||
If you change this mapping to something else: | |||
|
|||
.Exposing Swagger YAML | |||
[configuration] | |||
[source,yaml] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we want to keep using the configuration
macro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -1,7 +1,7 @@ | |||
If you wish to expose the generated OpenAPI yaml output from your running application you can simply add the necessary static resource to the application configuration. For example: | |||
|
|||
.Exposing OpenAPI YAML | |||
[configuration] | |||
[source,yaml] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we want to use the configuration
macro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -77,7 +77,7 @@ class MyJaxbElement3 { | |||
|
|||
And set openapi properties to map classes to custom openapi schema classes: | |||
|
|||
[configuartion] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we want to use the configuration
macro.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
# Conflicts: # gradle/libs.versions.toml
# Conflicts: # openapi/src/main/java/io/micronaut/openapi/visitor/AbstractOpenApiVisitor.java
# Conflicts: # openapi/src/main/java/io/micronaut/openapi/visitor/AbstractOpenApiVisitor.java
# Conflicts: # openapi/src/main/java/io/micronaut/openapi/visitor/AbstractOpenApiVisitor.java # openapi/src/main/java/io/micronaut/openapi/visitor/OpenApiApplicationVisitor.java
# Conflicts: # openapi/src/main/java/io/micronaut/openapi/visitor/AbstractOpenApiVisitor.java
please resolve the conflicts |
# Conflicts: # openapi/src/main/java/io/micronaut/openapi/visitor/AbstractOpenApiVisitor.java
@graemerocher done. Could you review all other fixes for 4.10? #1137, #1136, #1115 |
# Conflicts: # openapi/src/main/java/io/micronaut/openapi/visitor/AbstractOpenApiVisitor.java # openapi/src/main/java/io/micronaut/openapi/visitor/OpenApiApplicationVisitor.java
# Conflicts: # openapi/src/main/java/io/micronaut/openapi/visitor/AbstractOpenApiVisitor.java # openapi/src/main/java/io/micronaut/openapi/visitor/OpenApiApplicationVisitor.java