Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generator improvements #1088

Merged
merged 7 commits into from
Jun 30, 2023
Merged

Generator improvements #1088

merged 7 commits into from
Jun 30, 2023

Conversation

andriy-dmytruk
Copy link
Contributor

Improvements for:

  • Date time types
  • File types
  • formatting

@andriy-dmytruk andriy-dmytruk requested a review from melix June 27, 2023 14:09
@andriy-dmytruk andriy-dmytruk force-pushed the andriy/generator-improve branch from ced69fa to 578c570 Compare June 27, 2023 14:37
@andriy-dmytruk andriy-dmytruk force-pushed the andriy/generator-improve branch from 578c570 to 480a265 Compare June 30, 2023 15:01
@andriy-dmytruk
Copy link
Contributor Author

Rebased and added 2 improvements:

  • change the test spec to 3.0.0
  • Improve chainable setters for parent properties

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 13 Code Smells

10.9% 10.9% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@graemerocher graemerocher merged commit 1fce141 into master Jun 30, 2023
@graemerocher graemerocher deleted the andriy/generator-improve branch June 30, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melix melix melix approved these changes

@graemerocher graemerocher Awaiting requested review from graemerocher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andriy-dmytruk @melix @graemerocher