Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI to RC1 #1068

Merged
merged 2 commits into from
Jun 19, 2023
Merged

OpenAPI to RC1 #1068

merged 2 commits into from
Jun 19, 2023

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Jun 19, 2023

No description provided.

@sdelamo sdelamo added the type: dependency-upgrade Upgrade a dependency label Jun 19, 2023
@@ -17,8 +17,7 @@ swagger-parser = "1.0.66"
swagger-parser-v3 = "2.1.14"
javaparser = "3.25.3"

micronaut = "4.0.0-M7"
micronaut-core = "4.0.0-M7"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timyates can you check the failure. it seems this build duplicated the micronaut core version.

@timyates timyates requested a review from melix June 19, 2023 08:34
@timyates
Copy link
Contributor

@melix Does this look ok? (I believe the micronaut-core version was added by yourself. I've switched to using the micronaut version as a provider instead of duplicating the version?

@melix
Copy link
Contributor

melix commented Jun 19, 2023

@timyates looks good, for some reason the asProvider() wasn't working for me.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@timyates timyates merged commit 9cc70d1 into master Jun 19, 2023
@timyates timyates deleted the sdelamo-patch-2 branch June 19, 2023 08:47
@timyates
Copy link
Contributor

@sdelamo Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade Upgrade a dependency
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants