Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StreamingFileUploadRequest #424

Merged
merged 10 commits into from
Nov 12, 2024
Merged

Conversation

johanra
Copy link
Contributor

@johanra johanra commented Feb 19, 2024

This PR contributes contains an implementation of StreamingFileUploadRequest and at the same time fixes #423 where the Azure implementation is calling getInputStream of the StreamingFileUploadRequest twice

@CLAassistant
Copy link

CLAassistant commented Feb 19, 2024

CLA assistant check
All committers have signed the CLA.

@alvarosanchez alvarosanchez self-assigned this Feb 19, 2024
@sdelamo sdelamo changed the base branch from master to 2.4.x March 27, 2024 07:16
@sdelamo sdelamo requested a review from alvarosanchez March 27, 2024 07:16
@sdelamo
Copy link
Contributor

sdelamo commented Mar 27, 2024

Thanks @johanra Can you sign the CLA?

@sdelamo sdelamo added the type: improvement A minor improvement to an existing feature label Mar 27, 2024
@johanra
Copy link
Contributor Author

johanra commented Mar 28, 2024

@sdelamo CLA is signed now

*
* An {@link UploadRequest} backed by a {@link StreamingFileUpload}.
*/
public class StreamingFileUploadRequest implements UploadRequest {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add @since to javadoc

@marcinfigiel
Copy link

Hi Guys,
Wouldn't it make sense to extend this PR to allow streaming uploads to other cloud providers too? Right now it adds the abstraction, but implementation is limited to Azure only.

@sdelamo sdelamo changed the base branch from 2.4.x to 2.5.x April 16, 2024 14:11
@scprek
Copy link

scprek commented Apr 29, 2024

Hi Guys, Wouldn't it make sense to extend this PR to allow streaming uploads to other cloud providers too? Right now it adds the abstraction, but implementation is limited to Azure only.

I have the same question, specifically so we can use with AWS

@marcinfigiel
Copy link

What is the current status of this topic? Has it stalled?

@wgruszczyk
Copy link

Hi!
Any chance to close this ticket any time soon? We're waiting for the feature and need to make a decision to either wait or workaround this limitation.

@sdelamo sdelamo changed the base branch from 2.5.x to 2.7.x November 8, 2024 10:06
@sdelamo sdelamo merged commit 917573f into micronaut-projects:2.7.x Nov 12, 2024
8 of 10 checks passed
@sdelamo
Copy link
Contributor

sdelamo commented Nov 12, 2024

@johanra Thanks for the contribution
@wgruszczyk @marcinfigiel @scprek I am going to merge this and it will be part of 4.7.0. We can add support to other cloud vendors later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement A minor improvement to an existing feature
Projects
No open projects
Status: No status
Status: Done
Development

Successfully merging this pull request may close these issues.

Uploading a blob through a Controller using StreamingFileUpload fails on Azure
8 participants