Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests for Docker packagings #962

Merged
merged 16 commits into from
Jan 24, 2024
Merged

Add more tests for Docker packagings #962

merged 16 commits into from
Jan 24, 2024

Conversation

alvarosanchez
Copy link
Member

@alvarosanchez alvarosanchez commented Jan 23, 2024 •
edited
Loading

This PR improves the integration tests for all Docker packagings, by actually running the produced Docker images and verifying that they work.

In doing so, many things have been fixed, including:

  • Fixing CRaC packaging by exposing the server port as all the other packagings do.
  • Updating integration tests' POM structure for Micronaut 4. They were carried over from Micronaut 3 and not fully updated until now.
  • Setting cgr.dev/chainguard/wolfi-base:latest as the base image for all CPU architectures, not just ARM, since frolvlad/alpine-glibc:glibc-2.34 was giving issues.
  • Using the official GraalVM musl-based Docker images for static native images (fixes Use the official musl-based image for static native images #775).

@alvarosanchez alvarosanchez mentioned this pull request Jan 24, 2024
Closed
@alvarosanchez alvarosanchez marked this pull request as ready for review January 24, 2024 10:48
@alvarosanchez alvarosanchez requested a review from melix January 24, 2024 10:50
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@alvarosanchez alvarosanchez added this pull request to the merge queue Jan 24, 2024
Merged via the queue into master with commit 1fe6835 Jan 24, 2024
6 checks passed
@alvarosanchez alvarosanchez deleted the docker_tests branch January 24, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melix melix melix approved these changes

@timyates timyates Awaiting requested review from timyates

@n0tl3ss n0tl3ss Awaiting requested review from n0tl3ss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the official musl-based image for static native images
2 participants
@alvarosanchez @melix