Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GraalVM download URL on Amazon Linux for AWS Lambda #1219

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Fix GraalVM download URL on Amazon Linux for AWS Lambda #1219

merged 3 commits into from
Oct 22, 2024

Conversation

alvarosanchez
Copy link
Member

No description provided.

@alvarosanchez alvarosanchez added the type: bug Something isn't working label Oct 22, 2024
melix
melix approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@melix melix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm, I guess the Gradle plugin needs a similar update? That's quite a difference, not only this changes the GraalVM download URL, but also how the Amazon functions are built.

@alvarosanchez
Copy link
Member Author

mmm, I guess the Gradle plugin needs a similar update? That's quite a difference, not only this changes the GraalVM download URL, but also how the Amazon functions are built.

It does, Gradle builds are as broken as Maven ones in this regard.

The functions are built the same, just took the opportunity to improve/clean the Dockefiles.

melix added a commit to micronaut-projects/micronaut-gradle-plugin that referenced this pull request Oct 22, 2024
@melix
Fix GraalVM download URL
0e507f5 
This is the Gradle's counterpart to micronaut-projects/micronaut-maven-plugin#1219

The fix is slightly different since we already had a way to define the base path, but not the full path.
Now the plugin provides the option to completely override the GraalVM download URL, in case the derivation
from the JDK and arch properties is not good enough.
@alvarosanchez alvarosanchez merged commit 58d02a5 into 4.7.x Oct 22, 2024
5 checks passed
@alvarosanchez alvarosanchez deleted the fix_docker_native_lambda branch October 22, 2024 11:31
melix added a commit to micronaut-projects/micronaut-gradle-plugin that referenced this pull request Oct 22, 2024
@melix
Fix graalvm download url (#1041)
fe4b58e 
* Fix GraalVM download URL

This is the Gradle's counterpart to micronaut-projects/micronaut-maven-plugin#1219

The fix is slightly different since we already had a way to define the base path, but not the full path.
Now the plugin provides the option to completely override the GraalVM download URL, in case the derivation
from the JDK and arch properties is not good enough.

* Update Amazon Linux base image
melix added a commit to micronaut-projects/micronaut-gradle-plugin that referenced this pull request Oct 22, 2024
@melix
Fix graalvm download url (#1041)
62690f9 
* Fix GraalVM download URL

This is the Gradle's counterpart to micronaut-projects/micronaut-maven-plugin#1219

The fix is slightly different since we already had a way to define the base path, but not the full path.
Now the plugin provides the option to completely override the GraalVM download URL, in case the derivation
from the JDK and arch properties is not good enough.

* Update Amazon Linux base image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melix melix melix approved these changes

@graemerocher graemerocher graemerocher approved these changes

@sdelamo sdelamo Awaiting requested review from sdelamo

Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alvarosanchez @graemerocher @melix