Update the major version of Ktor #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes in core are also required: |
|
Kudos, SonarCloud Quality Gate passed! |
… to 4.0.6, spock to 2.3-groovy-4.0, github workflows to Java 17 (#439)
….3.0 (#444) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
….15 (#438) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Bumps [mikepenz/action-junit-report](https://github.com/mikepenz/action-junit-report) from 3.0.2 to 3.0.3. - [Release notes](https://github.com/mikepenz/action-junit-report/releases) - [Commits](mikepenz/action-junit-report@v3.0.2...v3.0.3) --- updated-dependencies: - dependency-name: mikepenz/action-junit-report dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sergio del Amo <[email protected]>
- groovy to 3.0.12
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
timyates
reviewed
Nov 29, 2022
There was a problem hiding this comment.
Not sure what the failure is... It could be micronaut-projects/micronaut-core#8419
kotlin-runtime/src/main/kotlin/io/micronaut/kotlin/converters/FlowConverterRegistrar.java
Outdated
Show resolved
Hide resolved
ktor/src/main/kotlin/io/micronaut/ktor/env/MicronautKtorEnvironmentConfig.kt
Outdated
Show resolved
Hide resolved
This reverts commit 949d6a8.
…nmentConfig.kt Co-authored-by: Tim Yates <[email protected]>
# Conflicts: # examples/greeting/build.gradle # gradle/libs.versions.toml
timyates
approved these changes
Dec 6, 2022
1 task
sdelamo
approved these changes
Dec 8, 2022
# Conflicts: # kotlin-extension-functions/src/test/kotlin/io/micronaut/kotlin/context/BeanContextExtensionsTest.kt
|
@wetted can you resolve the conflict? |
# Conflicts: # gradle/libs.versions.toml
|
The GraalVM job is failing with |
|
@wetted Can you try applying micronaut-projects/micronaut-project-template#309 here to the graal workflow? |
[kotlin] Update common files for branch master
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #413
This also fixes a prior [seemingly] bug where
MicronautKtorEnvironmentConfig.property(path)erroneously prefixedpathwith just a dot character ifprefixwas empty (but not null), causing the call toenv.containsPropertyto fail. @graemerocher can you double check this for me please? I'm not 100% sure I understand how the new collection viewskeys()andtoMap()should really look, with respect toEnvironment, not to mention myKotlinkung-fu is a work in progress. ;)