Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AWS SDK v2 for SQS #329

Merged
merged 10 commits into from
Mar 2, 2023
Merged

Conversation

charlie-harvey
Copy link
Contributor

Things that need review:

  • I removed the SqsClientFactory. It was not getting picked up. I had to add a SqsClientBuilderListener instead. This is just to get the test queue created before the test starts so its probably not that weird.
  • I don't know all the changes that need to be made to the native-image.properties, proxy-config.json, reflect-config.json, resourse-config.json.

@alvarosanchez alvarosanchez linked an issue Feb 16, 2023 that may be closed by this pull request
@charlie-harvey
Copy link
Contributor Author

Not sure what the secret sauce is here. Compilations and tests all pass locally. Same jdk, same graal. And I don't know what the other error is about.

@charlie-harvey
Copy link
Contributor Author

Any chance someone could authorize a build? Or maybe take a look to see what might be wrong?

Thanks.

@charlie-harvey
Copy link
Contributor Author

Another meaningless failure. Is there a way to see the test result or a stack trace?

@graemerocher
Copy link
Contributor

I have forked the PR to #339 this will allow us to see Gradle build scans which might help diagnose the issue

@charlie-harvey
Copy link
Contributor Author

I hard coded the fake test credentials in a different way so they won't get flagged.

@charlie-harvey
Copy link
Contributor Author

The failure has become even more esoteric. It seems it failed this time just because I don't have Sonar permissions. But that's just a guess.

@graemerocher
Copy link
Contributor

it passed the main build, so think we are good

@graemerocher graemerocher added enhancement New feature or request type: enhancement New feature or request labels Mar 2, 2023
@graemerocher graemerocher merged commit f5bb8bc into micronaut-projects:master Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for AWS SDK v2
2 participants