build: master to MN 4

[sdelamo]

No description provided.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[wetted]

@sdelamo I am trying to resolve a broken test. In the test, CustomizeBrokerSpec (there is a copy for each language, they all fail the same way).

    @Test
    void testCustomizeBroker() {

        ConnectionFactory connectionFactory = applicationContext.getBean(
            ConnectionFactory.class,
            Qualifiers.byName(CONNECTION_FACTORY_BEAN_NAME));

        assertTrue(connectionFactory instanceof JMSConnectionPool);

        ...

That assert is failing , where it passes on the branch for the MN 3 version of the module. The bean is registered in this method,

    public void process(BeanDefinition<?> beanDefinition, BeanContext context) {
        final Object candidate = context.getBean(beanDefinition);
        Assert.isTrue(candidate instanceof ConnectionFactory,
            () -> "@JMSConnectionFactory can only be applied to a bean of type javax.jms.ConnectionFactory. " +
            "Provided class was " + candidate.getClass().getName());

        final ConnectionFactory connectionFactory = (ConnectionFactory) candidate;
        final String name = beanDefinition.stringValue(JMSConnectionFactory.class)
            .orElseThrow(() -> new ConfigurationException(
                "@JMSConnectionFactory must specify a name for the bean."));

        context.registerSingleton(
            JMSConnectionPool.class,
            new JMSConnectionPool(
                connectionFactory,
                properties.getInitialPoolSize(),
                properties.getMaxPoolSize()),
            Qualifiers.byName(name));

        logger.debug("created JMSConnectionPool bean '{}' for ConnectionFactory {}",
            name, connectionFactory.getClass().getName());
    }

The logger output here is, "created JMSConnectionPool bean 'activeMqConnectionFactory' for ConnectionFactory org.apache.activemq.ActiveMQConnectionFactory"

I'm not understanding why this fails now. Could it be an issue with the registerSingleton(...) method?

@graemerocher previously stated (when I asked), "the approach taken here looks like a hack
but probably the exposed type doesn't expose ConnectionFactory as a bean".

So what's the hack, the process() method or the test (or both)? Now that I look closer, the test was changed in September, and if I revert that change to what it was, it passes? So what is the right thing?

class CustomizeBrokerSpec extends AbstractJmsSpec {

    @Test
    void testCustomizeBroker() {

        ConnectionFactory connectionFactory = applicationContext.getBean(
            ConnectionFactory.class,
            Qualifiers.byName(CONNECTION_FACTORY_BEAN_NAME));

        assertTrue(connectionFactory instanceof ActiveMQConnectionFactory);

        ActiveMQConnectionFactory amqcf = (ActiveMQConnectionFactory) connectionFactory;

        assertTrue(amqcf.isUseAsyncSend());
    }
}

Note that my last commit was to push that reverted change, but that doesn't mean I think it's the correct thing to do.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication