Move to jakarta and Hibernate Validator 8 #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Java CI failed: https://ge.micronaut.io/s/luja7isu2a4bs |
|
❌ GraalVM CE CI 17 latest failed: https://ge.micronaut.io/s/u2dgcjieg2aww |
|
❌ GraalVM CE CI 17 latest failed: https://ge.micronaut.io/s/56ul3xfja3lni |
|
❌ Java CI failed: https://ge.micronaut.io/s/kiawccqa6voj4 |
graemerocher
changed the title
|
Kudos, SonarCloud Quality Gate passed! |
sdelamo
reviewed
Apr 26, 2023
|
|
||
| testAnnotationProcessor mnValidation.micronaut.validation.processor |
There was a problem hiding this comment.
@radovanradic why did we add a dependency to Micronaut-validation? Should not hibernate validator be independent of micronaut-validation ?
There was a problem hiding this comment.
It already had dependency to micronaut validation, this was just moving to new validation library that was moved out of core 978b7b2#diff-00f11a022501c4834933545068afa17566c38f250fc67a4f28c825987d63576dL12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to move sql and data to new validation and I think this is the first thing that needs to be updated.
However,
compileTestGroovytask if failing with this errorDon't see where this class is referred.