Use Chainguard's Wolfi base image by default #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR uses `cgr.dev/chainguard/wolfi-base:latest` as the default base image for all CPU architectures, not only for ARM, since it is multi-platform and a bit smaller than `frolvlad/alpine-glibc`
melix
approved these changes
Jan 30, 2024
| @@ -16,3 +16,7 @@ datasources: | |||
| # driverClassName: org.postgresql.Driver | |||
| # schema-generate: CREATE_DROP | |||
| # dialect: POSTGRES | |||
| test-resources: | |||
There was a problem hiding this comment.
Sorry for interfering, just to ask can you try using test-containers 1.19.4 in this PR, maybe these mysql overrides won't be needed?
https://github.com/testcontainers/testcontainers-java/releases/tag/1.19.4 contains fix for MySQL it seems.
There was a problem hiding this comment.
Yes, I plan to test that version, but not in that PR, reason being that it's driven by test resources, not the Gradle plugin.
There was a problem hiding this comment.
Ah, sorry, I assume it is test-resources as soon as I see your name:)
|
melix
added a commit
to micronaut-projects/micronaut-test-resources
that referenced
this pull request
Jan 30, 2024
This should fix the problem with the mysql:latest image not being compatible, as seen in several places like micronaut-projects/micronaut-gradle-plugin#927 or micronaut-projects/micronaut-test#936 or https://github.com/micronaut-projects/micronaut-test-resources/pull/503/files
melix
added a commit
to micronaut-projects/micronaut-test-resources
that referenced
this pull request
Jan 30, 2024
* Upgrade testcontainers dependency This should fix the problem with the mysql:latest image not being compatible, as seen in several places like micronaut-projects/micronaut-gradle-plugin#927 or micronaut-projects/micronaut-test#936 or https://github.com/micronaut-projects/micronaut-test-resources/pull/503/files * Revert testcontainers redis dependency As it is a breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses
cgr.dev/chainguard/wolfi-base:latestas the default base image for all CPU architectures, not only for ARM, since it is multi-platform and a bit smaller thanfrolvlad/alpine-glibc