Checkstyle fixes (#878)

crac-plugin/src/main/java/io/micronaut/gradle/crac/CRaCCheckpointDockerfile.java

@@ -16,7 +16,6 @@
 import org.gradle.api.tasks.TaskAction;
 import org.gradle.jvm.toolchain.JavaLanguageVersion;
 
-import java.io.IOException;
 import java.io.IOException;
 import java.nio.file.Files;
 import java.nio.file.Path;

crac-plugin/src/main/java/io/micronaut/gradle/crac/TeeStringWriter.java

@@ -18,13 +18,13 @@ public TeeStringWriter(Logger logger) {
 
     @Override
     @SuppressWarnings("java:S2629") // This is done by Gradle
-    public void write(char[] cbuf, int off, int len) throws IOException {
+    public void write(char[] cbuf, int off, int len) {
         delegate.write(cbuf, off, len);
         logger.lifecycle(new String(cbuf, off, len).trim());
     }
 
     @Override
-    public void flush() throws IOException {
+    public void flush() {
         delegate.flush();
     }
 

docker-plugin/src/main/java/io/micronaut/gradle/docker/MicronautDockerfile.java

@@ -54,6 +54,7 @@ public MicronautDockerfile() {
         this.targetWorkingDirectory = objects.property(String.class).convention(DEFAULT_WORKING_DIR);
     }
 
+    @Override
     public Property<String> getTargetWorkingDirectory() {
         return targetWorkingDirectory;
     }

docker-plugin/src/main/java/io/micronaut/gradle/docker/NativeImageDockerfile.java

@@ -86,15 +86,18 @@ public abstract class NativeImageDockerfile extends Dockerfile implements Docker
      */
     @Input
     @Optional
+    @Override
     public abstract Property<String> getBaseImage();
 
     /**
      * @return The arguments to pass to the native image executable when starting up in the docker container.
      */
     @Input
+    @Override
     public abstract ListProperty<String> getArgs();
 
     @Input
+    @Override
     public abstract ListProperty<Integer> getExposedPorts();
 
     /**
@@ -117,6 +120,7 @@ public abstract class NativeImageDockerfile extends Dockerfile implements Docker
 
     @Input
     @Optional
+    @Override
     public abstract Property<String> getDefaultCommand();
 
     /**

docker-plugin/src/main/java/io/micronaut/gradle/docker/editor/FingerprintingEditor.java

@@ -31,7 +31,6 @@ public class FingerprintingEditor implements Editor {
     private final List<String> fingerprint;
 
     // We use Optional because Gradle doesn't support injecting null values
-    @SuppressWarnings("OptionalUsedAsFieldOrParameterType")
     @Inject
     public FingerprintingEditor(ObjectFactory objects,
                                 List<String> fingerprint) {

docker-plugin/src/main/java/io/micronaut/gradle/docker/tasks/PrepareDockerContext.java

@@ -29,10 +29,10 @@
 /**
  * Prepares a docker build context directory by copying a number of
  * directories into the output directory.
- *
+ * <p>
  * We cannot use the regular Copy task because of laziness and the
  * fact that the directories to copy are generated by the build itself.
- *
+ * <p>
  * However, using `Copy` task is considered harmful in general.
  */
 public abstract class PrepareDockerContext extends DefaultTask {

functional-tests/src/test/groovy/io/micronaut/gradle/kotlin/KotlinLibraryFunctionalTest.groovy

@@ -7,10 +7,10 @@ import spock.lang.Shared
 class KotlinLibraryFunctionalTest extends AbstractEagerConfiguringFunctionalTest {
 
     @Shared
-    private final String kotlinVersion = System.getProperty("kotlinVersion");
+    private final String kotlinVersion = System.getProperty("kotlinVersion")
 
     @Shared
-    private final String kspVersion = System.getProperty("kspVersion");
+    private final String kspVersion = System.getProperty("kspVersion")
 
 
     def "test apply defaults for micronaut-library and KSP with kotlin DSL for #plugin"() {

minimal-plugin/src/main/java/io/micronaut/gradle/AnnotationProcessingConfigBuilder.java

@@ -1,6 +1,5 @@
 package io.micronaut.gradle;
 
-import org.gradle.api.artifacts.Configuration;
 import org.gradle.api.tasks.SourceSet;
 
 /**

minimal-plugin/src/main/java/io/micronaut/gradle/AttributeUtils.java

@@ -40,7 +40,7 @@ public static void copyAttributes(ProviderFactory providers, Configuration from,
             AttributeContainer runtimeClasspathAttributes = to.getAttributes();
             Set<Attribute<?>> keySet = runtimeClasspathAttributes.keySet();
             for (Attribute<?> attribute : keySet) {
-                //noinspection unchecked,DataFlowIssue
+                // noinspection unchecked
                 attrs.attributeProvider((Attribute<Object>) attribute, providers.provider(() -> runtimeClasspathAttributes.getAttribute(attribute)));
             }
         });

openapi-plugin/src/main/java/io/micronaut/gradle/openapi/tasks/OpenApiClientWorkAction.java

@@ -34,6 +34,7 @@ interface ClientParameters extends AbstractOpenApiWorkAction.OpenApiParameters {
         ListProperty<String> getAdditionalClientTypeAnnotations();
     }
 
+    @Override
     protected void configureBuilder(MicronautCodeGeneratorBuilder builder) {
         var parameters = getParameters();
         builder.forClient(spec -> {

openapi-plugin/src/main/java/io/micronaut/gradle/openapi/tasks/OpenApiServerWorkAction.java

@@ -25,6 +25,7 @@ interface ServerParameters extends OpenApiParameters {
         Property<Boolean> getUseAuth();
     }
 
+    @Override
     protected void configureBuilder(MicronautCodeGeneratorBuilder builder) {
         var parameters = getParameters();
         builder.forServer(spec -> {

openapi-plugin/src/test/resources/petstore.json

@@ -812,7 +812,7 @@
     },
     "petstore_auth": {
       "type": "oauth2",
-      "authorizationUrl": "http://petstore.swagger.io/api/oauth/dialog",
+      "authorizationUrl": "https://petstore.swagger.io/api/oauth/dialog",
       "flow": "implicit",
       "scopes": {
         "write:pets": "modify pets in your account",

test-resources-plugin/src/main/java/io/micronaut/gradle/testresources/MicronautTestResourcesPlugin.java

@@ -94,6 +94,7 @@ private static Configuration createTestResourcesClientConfiguration(Project proj
         return client;
     }
 
+    @Override
     public void apply(Project project) {
         PluginManager pluginManager = project.getPluginManager();
         pluginManager.apply(JavaPlugin.class);

test-resources-plugin/src/main/java/io/micronaut/gradle/testresources/TestResourcesConfiguration.java

@@ -46,7 +46,7 @@ public interface TestResourcesConfiguration extends KnownModules {
      * reuse that server, effectively ignoring the
      * existing configuration. This can be used to share
      * a server between multiple independent builds.
-     *
+     * <p>
      * If an explicit port is set, then security is lowered
      * and a token is no longer requested. Any client from
      * the loopback address can access the server.