Break circular dependency when zipkin tracing is enabled #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyg484
requested review from
timyates and
sdelamo
and removed request for
timyates
sdelamo
approved these changes
Feb 16, 2024
gcp-tracing/src/test/groovy/io/micronaut/gcp/tracing/zipkin/StackdriverConfigurationSpec.groovy
Show resolved
Hide resolved
…ackdriverConfigurationSpec.groovy
|
sdelamo
added a commit
that referenced
this pull request
Feb 16, 2024
* Break circular dependency when zipkin tracing is enabled * Update gcp-tracing/src/test/resources/logback.xml * Update gcp-tracing/src/test/groovy/io/micronaut/gcp/tracing/zipkin/StackdriverConfigurationSpec.groovy --------- Co-authored-by: Sergio del Amo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating the default http client in the constructor of
DefaultOAuth2HttpTransportFactorywas causing a circular dependency when Zipkin tracing is enabled. There were no tests forStackDriverSenderFactoryin thegcp-tracingmodule, thus the bug was undiscovered until users tried out the new release and reported the issue.DefaultOAuth2HttpTransportFactoryis updated to lazily create the default http client via a memoizedSupplier, in the same manner as we do in the Micronaut Security JWKS client, and this breaks the dependency cycle.A simple
StackdriverConfigurationSpecis added to reproduce the issue and verify the fix.This resolves #1045