-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove AuthenticationLoggingInterceptor #1014
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have a test that shows "Calling googleCredentials.refreshIfExpired() followed by googleCredentials.getAccessToken().getTokenValue() results in a null pointer exception." (from the issue) is now working?
(just so we don't break it again in the future?)
Yes, I think that's a good idea, I'll attempt it. I believe I'll have to add a new mock endpoint to return a "valid" token to get that to work correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice test! I checked it against master, and it fails as expected 🎉
Added a cleanup:
block to the tests to close the application context where applicable 👍
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Remove the
AuthenticationLoggingInterceptor
that was being applied toGoogleCredentials
via an AOP proxy.An alternate solution has been found to be able to detect and log the authentication failures (a separate PR forthcoming).
This will fix the issues with certain methods of
GoogleCredentials
being unable to be used as expected when proxied due to them being final.This fix can be applied in a patch release, clearing the way for the alternate authentication support to be part of the next minor release.
This closes #997.