Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the set Offset on JPA/Hibernate #2791

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

kareemelzayat
Copy link
Contributor

The PR is to use the correct method to set the SQL OFFSET

@CLAassistant
Copy link

CLAassistant commented Feb 12, 2024

CLA assistant check
All committers have signed the CLA.

@kareemelzayat kareemelzayat changed the base branch from 4.6.x to master February 12, 2024 14:56
@kareemelzayat
Copy link
Contributor Author

@dstepanov I could not target the 4.6.x branch from my forked project. But I suppose you can! You can just cherry-pick this comment into a new PR that targets the branch

@dstepanov dstepanov changed the base branch from master to 4.6.x February 12, 2024 16:34
@dstepanov dstepanov changed the base branch from 4.6.x to master February 12, 2024 16:34
@kareemelzayat kareemelzayat changed the title Fork issue 2786 Fix the set Offset on JPA/Hibernate Feb 13, 2024
@kareemelzayat
Copy link
Contributor Author

@dstepanov can we merge this?

@kareemelzayat
Copy link
Contributor Author

@dstepanov I would like to have this as part of Micronaut 4.3.2. How can I achieve that?

@dstepanov
Copy link
Contributor

I will merge it

@dstepanov
Copy link
Contributor

@kareemelzayat Can you please resign the CLA?

@kareemelzayat
Copy link
Contributor Author

@dstepanov done 👍

@dstepanov dstepanov merged commit f94dedf into micronaut-projects:master Feb 14, 2024
38 checks passed
dstepanov pushed a commit that referenced this pull request Feb 16, 2024
Co-authored-by: Kareem Elzayat <[email protected]>
(cherry picked from commit f94dedf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants