Add support for sequence type for h2 #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there are failing tests |
|
|
|
Rebased. Github doesn't see signed CLA for some reason |
|
Weird exception. Looks like API changed https://github.com/micronaut-projects/micronaut-data/pull/1789/checks#step:8:13024 @dstepanov if you have idea what it is it'll be helpful. I'll take a look later |
radovanradic
reviewed
Feb 8, 2024
| def queryModel = QueryModel.from(entity).eq("name", QueryParameter.of("name")) | ||
|
|
||
| expect: | ||
| builder.dialect == Dialect.H2 |
There was a problem hiding this comment.
I think buildQuery method has been changed in 4.0 here #2323 (comment) and need AnnotationMetadata so just need to add this AnnotationMetadata.EMPTY_METADATA as first parameter, for example.
There was a problem hiding this comment.
@radovanradic I fixed failing test
rlconst
force-pushed
the
h2-sequence
branch
3 times, most recently
from
5997e13
to
f96ab3b
Compare
radovanradic
approved these changes
May 13, 2024
|
Please target 4.9 |
4.8.x is fine. 4.8.x is the next major branch. |
|
Thanks for the contribution! |
radovanradic
added a commit
that referenced
this pull request
Jun 2, 2024
This PR had test failures: #1789
radovanradic
added a commit
that referenced
this pull request
Jun 3, 2024
This PR had test failures: #1789
graemerocher
pushed a commit
that referenced
this pull request
Jun 3, 2024
* Fix H2 tests after latest merge for H2 generate schema changes This PR had test failures: #1789
radovanradic
added a commit
that referenced
this pull request
Jun 3, 2024
* Update common files * Fix H2 tests after latest merge for H2 generate schema changes (#2964) * Fix H2 tests after latest merge for H2 generate schema changes This PR had test failures: #1789 * Update common files --------- Co-authored-by: Radovan Radic <[email protected]>
radovanradic
added a commit
that referenced
this pull request
Jun 4, 2024
* Test for many to many join issue * Fix H2 tests after latest merge for H2 generate schema changes This PR had test failures: #1789 * Fixed one more test for H2 * Fix H2 tests after latest merge for H2 generate schema changes (#2964) * Fix H2 tests after latest merge for H2 generate schema changes This PR had test failures: #1789 * Test for many to many join issue * Fix join issue * Checkstyle --------- Co-authored-by: Denis Stepanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rough attempt to support sequence types for H2 http://www.h2database.com/html/grammar.html#column_definition