Prevent issue where micronaut-data-tx was required on the classpath #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timyates
changed the title
|
@sdelamo Ready for review I think |
|
IntelliJ says we have 81% coverage overall... I suspect Sonar isn't taking the test-suites into account 🤔 |
* Simplify composite * Extract common code to method --------- Co-authored-by: Tim Yates <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
|
@timyates This PR should have been merged with squash and merge. |
|
🙀 Sorry about that :-( |
sdelamo
pushed a commit
that referenced
this pull request
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #68 it was discovered that we assumed micronaut-data-tx was on the classpath, and if this was not the case, the application would fail with a ClassNotFoundException
This change introduces resolvers which fetch the HikariDataSource if one exists (unwrapping from a DelegatingDataSource if one exists) without requiring them both on the classpath.