Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct version of Logback to get the build working #49

Merged
merged 9 commits into from
Dec 13, 2022

Conversation

timyates
Copy link
Contributor

Something is pulling in an old version of logback, which has bindings targeting slf4j-api versions 1.7.x or earlier.

Since we have moved to SLF4J 2.x, this causes an error.

I believe the cause is an old version of logback in the micronaut-bom, but until that is brought up to date, this is a temporary workaround

Something is pulling in an old version of logback, which has bindings targeting slf4j-api versions 1.7.x or earlier.

Since we have moved to SLF4J 2.x, this causes an error.

I believe the cause is an old version of logback in the micronaut-bom, but until that is brought up to date, this is a
temporary workaround
@timyates timyates added the relates-to: build label for issues related to the build file or CI label Nov 21, 2022
@timyates timyates requested a review from sdelamo November 21, 2022 10:55
@timyates
Copy link
Contributor Author

The old settings plugin was pulling in an old snapshot, so we got an incompatible logback.

This change switched to use the latest settings plugin, and imports the catalogs for the
required sql and serde libs.
Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not data have a bom?

@timyates
Copy link
Contributor Author

It does, but we get errors when trying to import the catalog

https://ge.micronaut.io/s/dhmndf6vwgcoy/console-log?page=1#L3

@melix any idea what these mean?

@timyates
Copy link
Contributor Author

Cédric worked it out... I wasn't looking in the right repos 😓

Should be fixed now @sdelamo

@sonarcloud
Copy link

sonarcloud bot commented Dec 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@timyates
Copy link
Contributor Author

Merging this

@timyates timyates merged commit e625211 into master Dec 13, 2022
@timyates timyates deleted the fix-logging branch December 13, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relates-to: build label for issues related to the build file or CI
Projects
No open projects
Status: Done
Status: Done
2 participants