Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add micronaut-platform for test-suites #192

Merged
merged 4 commits into from
Sep 11, 2023
Merged

Add micronaut-platform for test-suites #192

merged 4 commits into from
Sep 11, 2023

Conversation

timyates
Copy link
Contributor

@timyates timyates commented Sep 8, 2023

We were expecting the platform and core versions to be the same

For some of the test-suite tests, we use the official Gradle plugins, which use the micronaut version.

This change adds platform, and switches to using this.

Also updates redis and shared settings

Here we added the core BOM to the catalog

#118

I assume this was so we get rennovate updates for micronaut releases

However I believe we should be tracking the platform, not core...

Also, we were degrading the platform version for milestones of 4.0.0
@timyates timyates added the relates-to: build label for issues related to the build file or CI label Sep 8, 2023
@timyates timyates added this to the 2.0.4 milestone Sep 8, 2023
@timyates timyates requested review from sdelamo and n0tl3ss September 8, 2023 12:59
@timyates timyates self-assigned this Sep 8, 2023
@timyates timyates changed the title Stop tracking core and stop using milestone platform Add micronaut-platform for test-suites Sep 11, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sdelamo sdelamo merged commit fdd0440 into 2.0.x Sep 11, 2023
7 checks passed
@sdelamo sdelamo deleted the fix-core-platform branch September 11, 2023 09:52
sdelamo added a commit that referenced this pull request Sep 11, 2023
* Update for next minor (Micronaut 4.2.0)

Pushed a 2.0.x branch from master prior to this PR

* Stop using milestone platform

See #192

* chore(deps): update kotlin monorepo to v1.9.10

* chore(deps): update slsa-framework/slsa-github-generator action to v1.9.0

* Proper fix

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Sergio del Amo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relates-to: build label for issues related to the build file or CI
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants