Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace DEFAULT_EVENT_LOOP_THREADS with a lazy getter #9815

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Replace DEFAULT_EVENT_LOOP_THREADS with a lazy getter #9815

merged 1 commit into from
Oct 23, 2023

Conversation

yawkat
Copy link
Member

@yawkat yawkat commented Sep 1, 2023

Calling availableProcessors is expensive and usually not necessary.

@yawkat
Replace DEFAULT_EVENT_LOOP_THREADS with a lazy getter
8eea335 
Calling availableProcessors is expensive and usually not necessary.
@yawkat yawkat added the type: improvement A minor improvement to an existing feature label Sep 1, 2023
@yawkat yawkat added this to the 4.2.0 milestone Sep 1, 2023
@graemerocher
Copy link
Contributor

failing?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@yawkat
Copy link
Member Author

yawkat commented Sep 11, 2023

also flaky

@sdelamo
Copy link
Contributor

sdelamo commented Sep 11, 2023

@yawkat please remember to add prs and issues to GitHub Projects.

@graemerocher graemerocher merged commit b5425c2 into 4.2.x Oct 23, 2023
@graemerocher graemerocher deleted the lazy-event-loop-threads branch October 23, 2023 09:57
This was referenced Feb 6, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstepanov dstepanov dstepanov approved these changes

@graemerocher graemerocher Awaiting requested review from graemerocher

Assignees
No one assigned
Labels
type: improvement A minor improvement to an existing feature
Projects
4.2.0 Release
Status: Done
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@yawkat @graemerocher @sdelamo @dstepanov