-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kotlin to 1.9.10 #9793
Update kotlin to 1.9.10 #9793
Conversation
@timyates see if you can make it pass. |
Starting point https://ge.micronaut.io/s/ffg3lcvxu5vvy
|
Ok, one failure https://ge.micronaut.io/s/a4hp6gehhurja/tests/overview?outcome=FAILED Hopefully fixed by 040041a |
@melix Any idea why we're seeing
https://ge.micronaut.io/s/x33xdbydcmbke/console-log?page=1#L24 What it says doesn't seem to be the case 🤔 EditIs this the fix? 6b28a0f |
You need to update gradle.properties |
Which bit? I've already bumped the kotlin version 🤔 |
The bit that says kotlinVersion |
@dstepanov I already had done in f33adbf And now I'm seeing if it works with it removed in 6b28a0f |
Sorry I didn't see it in diff |
Going to investigate the deprecations https://ge.micronaut.io/s/xwtd572yhxyby/console-log?page=1#L149 later...So it looks like the ComponentRegistrar deprecation/removal has been delayed so I guess we can ignore for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test no longer throws an exception. I am not sure why...maybe the KAPT update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tried and the exception is io.micronaut.core.reflect.exception.InstantiationException: Argument count [2] doesn't match required argument count: 0
Maybe the constructor order is different.
I see the same test without the exception in KSP so it should be fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This label was duplicated, I removed the general one and left the more specific
...src/main/kotlin/io/micronaut/annotation/processing/test/support/AbstractKotlinCompilation.kt
Show resolved
Hide resolved
ping @melix |
I would like to merge this PR into 4.2.x @melix or @graemerocher would you like to review it? |
Kudos, SonarCloud Quality Gate passed! |
No description provided.