Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kotlin to 1.9.10 #9793

Merged
merged 10 commits into from
Sep 11, 2023
Merged

Update kotlin to 1.9.10 #9793

merged 10 commits into from
Sep 11, 2023

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Aug 29, 2023

No description provided.

@sdelamo sdelamo added the type: dependency-upgrade Upgrade a dependency label Aug 29, 2023
@sdelamo sdelamo added this to the 4.2.0 milestone Aug 29, 2023
@sdelamo sdelamo changed the base branch from 4.1.x to 4.2.x August 29, 2023 14:54
@sdelamo
Copy link
Contributor Author

sdelamo commented Aug 29, 2023

@timyates see if you can make it pass.

@timyates
Copy link
Contributor

Starting point https://ge.micronaut.io/s/ffg3lcvxu5vvy

:inject-kotlin-test:compileKotlin FAILED
:test-suite-kotlin:kaptTestKotlin FAILED
:context-propagation:compileTestKotlin FAILED

@timyates
Copy link
Contributor

Ok, one failure

https://ge.micronaut.io/s/a4hp6gehhurja/tests/overview?outcome=FAILED

Hopefully fixed by 040041a

@timyates
Copy link
Contributor

timyates commented Aug 30, 2023

@melix Any idea why we're seeing

The Kotlin Gradle plugin was loaded multiple times in different subprojects, which is not supported and may break the build. 	
This might happen in subprojects that apply the Kotlin plugins with the Gradle 'plugins { ... }' DSL if they specify explicit versions, even if the versions are equal.	
Please add the Kotlin plugin to the common parent project or the root project, then remove the versions in the subprojects.	
If the parent project does not need the plugin, add 'apply false' to the plugin line.	
See: https://docs.gradle.org/current/userguide/plugins.html#sec:subprojects_plugins_dsl	
The Kotlin plugin was loaded in the following projects: ':aop', ':inject-kotlin'

https://ge.micronaut.io/s/x33xdbydcmbke/console-log?page=1#L24

What it says doesn't seem to be the case 🤔

Edit

Is this the fix? 6b28a0f

@dstepanov
Copy link
Contributor

You need to update gradle.properties

@timyates
Copy link
Contributor

You need to update gradle.properties

Which bit? I've already bumped the kotlin version 🤔

@dstepanov
Copy link
Contributor

The bit that says kotlinVersion

@timyates
Copy link
Contributor

@dstepanov I already had done in f33adbf

And now I'm seeing if it works with it removed in 6b28a0f

@dstepanov
Copy link
Contributor

Sorry I didn't see it in diff

@timyates
Copy link
Contributor

timyates commented Aug 30, 2023

Going to investigate the deprecations

https://ge.micronaut.io/s/xwtd572yhxyby/console-log?page=1#L149

later...

So it looks like the ComponentRegistrar deprecation/removal has been delayed so I guess we can ignore for now.

@timyates timyates requested review from graemerocher and melix August 30, 2023 11:01
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test no longer throws an exception. I am not sure why...maybe the KAPT update?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried and the exception is io.micronaut.core.reflect.exception.InstantiationException: Argument count [2] doesn't match required argument count: 0
Maybe the constructor order is different.
I see the same test without the exception in KSP so it should be fine

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This label was duplicated, I removed the general one and left the more specific

@timyates timyates marked this pull request as ready for review August 30, 2023 11:03
@sdelamo
Copy link
Contributor Author

sdelamo commented Aug 31, 2023

ping @melix

@sdelamo
Copy link
Contributor Author

sdelamo commented Sep 8, 2023

I would like to merge this PR into 4.2.x

@melix or @graemerocher would you like to review it?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sdelamo sdelamo merged commit dd8fee0 into 4.2.x Sep 11, 2023
@sdelamo sdelamo deleted the update-kotlin branch September 11, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade Upgrade a dependency
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants