Add StreamingFileUpload.asInputStream #9787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repurpose some existing publisher->stream code to implement StreamingFileUpload.asInputStream. This will be useful for micronaut-projects/micronaut-object-storage#113
|
actually i'm going to make PublisherAsBlocking less abstract again. |
graemerocher
requested changes
Aug 28, 2023
| * @return An {@link InputStream} that reads this file's contents | ||
| * @since 4.2.0 | ||
| */ | ||
| default InputStream asInputStream() { |
There was a problem hiding this comment.
add @NonNull to return type
There was a problem hiding this comment.
annotate with @Blocking
There was a problem hiding this comment.
the method itself is not blocking even though the stream might be. should it still be annotated as such?
http-netty/src/main/java/io/micronaut/http/netty/PublisherAsBlocking.java
Show resolved
Hide resolved
|
SonarCloud Quality Gate failed.
|
http-server-netty/src/main/java/io/micronaut/http/server/netty/multipart/NettyPartData.java
Show resolved
Hide resolved
timyates
approved these changes
Aug 29, 2023
graemerocher
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repurpose some existing publisher->stream code to implement StreamingFileUpload.asInputStream. This will be useful for micronaut-projects/micronaut-object-storage#113