Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvement and cleanup of PropertySourcePropertyResolver #9766

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

dstepanov
Copy link
Contributor

Added hashcode/equals for ConversionCacheKey to avoid invokeDynamic overhead
Improvements: style, fast returns, generics, primitive types, collection of size creation

Copy link
Member

@yawkat yawkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im going to trust you on the style changes, this diff is awful to read 😆


@Override
public int hashCode() {
return name.hashCode();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why only the name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that in most cases, the property is represented by one type

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

75.5% 75.5% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@dstepanov dstepanov added the type: improvement A minor improvement to an existing feature label Aug 23, 2023
@dstepanov dstepanov added this to the 4.2.0 milestone Aug 23, 2023
@dstepanov dstepanov merged commit 4a503e6 into 4.2.x Aug 23, 2023
@dstepanov dstepanov deleted the perfcx branch August 23, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement A minor improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants