Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge up 4.0.x into 4.1.x #9761

Merged
merged 4 commits into from
Aug 24, 2023
Merged

Merge up 4.0.x into 4.1.x #9761

merged 4 commits into from
Aug 24, 2023

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Aug 22, 2023

No description provided.

@sdelamo
Copy link
Contributor Author

sdelamo commented Aug 22, 2023

@dstepanov can you check the failures. Attempting to merge-up causes a lot of tests to start failing https://ge.micronaut.io/s/eozd3bv5w4jck I assume it is #9752

@dstepanov
Copy link
Contributor

@sdelamo Where is it failing? Looks like some Kotlin stuff

@sdelamo
Copy link
Contributor Author

sdelamo commented Aug 23, 2023

It does not fail on CI but it fails for me on MacOS:

./gradlew :test-suite-kotlin:test

https://ge.micronaut.io/s/xo37irwltiki2

Are you running MacOS @dstepanov ?

@timyates can you verify if it fails for you?

@dstepanov
Copy link
Contributor

It passes or me https://ge.micronaut.io/s/xp72qms7gchgy
You might have some corrupted cache

@timyates
Copy link
Contributor

@sdelamo Passes for me too... Even if I turn off PTS and the build cache

https://ge.micronaut.io/s/apdygb2lyztcg

@sdelamo
Copy link
Contributor Author

sdelamo commented Aug 23, 2023

🤷‍♂️. I will merge it if it passes.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.8% 81.8% Coverage
0.0% 0.0% Duplication

@sdelamo sdelamo merged commit 1fc06d7 into 4.1.x Aug 24, 2023
@sdelamo sdelamo deleted the mergeup branch August 24, 2023 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants