doc: proceed with RequestFilter and CompletableFuture #11285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdelamo
commented
Oct 29, 2024
| //tag::methods[] | ||
| @RequestFilter | ||
| @Nullable | ||
| public CompletableFuture<@Nullable HttpResponse<?>> filter(@NonNull HttpRequest<?> request) { |
There was a problem hiding this comment.
Please note that if you remove the @Nullable annotation. It does not work. This PR ensures the users finds the correct return type incantation. He needs to use CompletableFuture<@Nullable HttpResponse<?>> not CompletableFuture<HttpResponse<?>>.
Suggested change
| public CompletableFuture<@Nullable HttpResponse<?>> filter(@NonNull HttpRequest<?> request) { | |
| public CompletableFuture<HttpResponse<?>> filter(@NonNull HttpRequest<?> request) { |
sdelamo
force-pushed
the
doc-request-filter-completeablefuture-proceed
branch
from
4ac939d to
5cd988a
Compare
sdelamo
commented
Oct 29, 2024
.../micronaut/http/server/tck/tests/filter/RequestFilterCompletableFutureFutureProceedTest.java
Show resolved
Hide resolved
…ts/filter/RequestFilterCompletableFutureFutureProceedTest.java
|
It should be also possible to use |
…b.com:micronaut-projects/micronaut-core into doc-request-filter-completeablefuture-proceed
Documented and I added a test of |
dstepanov
approved these changes
Oct 29, 2024
sdelamo
commented
Oct 29, 2024
...io/micronaut/http/server/tck/tests/filter/RequestFilterCompletionStageFutureProceedTest.java
Show resolved
Hide resolved
…ts/filter/RequestFilterCompletionStageFutureProceedTest.java
yawkat
approved these changes
Oct 30, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.