Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate zstd compression #10766

Open
wants to merge 1 commit into
base: 4.5.x
Choose a base branch
from

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Apr 25, 2024

No description provided.

@CLAassistant
Copy link

CLAassistant commented Apr 25, 2024

CLA assistant check
All committers have signed the CLA.

@sdelamo sdelamo requested a review from yawkat May 3, 2024 13:50
@sdelamo
Copy link
Contributor

sdelamo commented May 3, 2024

@sullis tests fail. Could you looking into them?

Execution failed for task ':http-server-netty:test'.
> The following test methods could not be retried, which is unexpected. Please file a bug report at https://github.com/gradle/test-retry-gradle-plugin/issues
     io.micronaut.http.server.netty.CompressionSpec#decompression [contentEncoding: zstd, compressor: <io.netty.handler.codec.compression.ZstdEncoder@3696c204 blockSize=65536 compressionLevel=3 maxEncodeSize=33554432 buffer=null matcher=io.netty.util.internal.TypeParameterMatcher$ReflectiveMatcher@bf358f6 preferDirect=true added=false>, #7]
     io.micronaut.http.server.netty.Http3CompressionSpec#decompression [contentEncoding: zstd, compressor: <io.netty.handler.codec.compression.ZstdEncoder@7e7ea60f blockSize=65536 compressionLevel=3 maxEncodeSize=33554432 buffer=null matcher=io.netty.util.internal.TypeParameterMatcher$ReflectiveMatcher@bf358f6 preferDirect=true added=false>, #7]
     io.micronaut.http.server.netty.handler.PipeliningServerHandlerSpec#decompression parts to full [contentEncoding: zstd, compressor: <io.netty.handler.codec.compression.ZstdEncoder@156d7773 blockSize=65536 compressionLevel=3 maxEncodeSize=33554432 buffer=null matcher=io.netty.util.internal.TypeParameterMatcher$ReflectiveMatcher@8bf7bb3 preferDirect=true added=false>, #5]
     io.micronaut.http.server.netty.handler.PipeliningServerHandlerSpec#decompression parts to stream [contentEncoding: zstd, compressor: <io.netty.handler.codec.compression.ZstdEncoder@757771c9 blockSize=65536 compressionLevel=3 maxEncodeSize=33554432 buffer=null matcher=io.netty.util.internal.TypeParameterMatcher$ReflectiveMatcher@8bf7bb3 preferDirect=true added=false>, #5]
     io.micronaut.http.server.netty.handler.PipeliningServerHandlerSpec#decompression full to full [contentEncoding: zstd, compressor: <io.netty.handler.codec.compression.ZstdEncoder@136f26de blockSize=65536 compressionLevel=3 maxEncodeSize=33554432 buffer=null matcher=io.netty.util.internal.TypeParameterMatcher$ReflectiveMatcher@8bf7bb3 preferDirect=true added=false>, #5]

@sullis
Copy link
Contributor Author

sullis commented May 6, 2024

@sullis tests fail. Could you looking into them?

Yes. I will have time to look at the end of this week.

@sdelamo sdelamo modified the milestone: 4.7.0 Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants