Inline SameSiteConverter to fix Graalvm Dev build
#10466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstepanov
changed the title
SameSiteConverterSameSiteConverter to fix Graalvm Dev build
sdelamo
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
What build will this fix? https://github.com/micronaut-projects/micronaut-core/actions/runs/7808528100 ?
|
Well, it fixes our error, but there is another Junit related error. |
graemerocher
approved these changes
Feb 7, 2024
|
it will get us further in terms of passing the dev build ci. Then there is a mother problem with JUnit 5 that we can't address |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.