Deprecations fixes and minor improvements in gradle scripts #10036
Conversation
altro3
force-pushed
the
gradle-fixes
branch
3 times, most recently
from
75ba45b to
a0a28d6
Compare
| @@ -14,7 +14,7 @@ repositories { | |||
| mavenCentral() | |||
| } | |||
|
|
|||
| configurations.all { | |||
| configurations.configureEach { | |||
There was a problem hiding this comment.
This is actually not required. Configurations cannot be configured lazily. Actually using configureEach on the configuration container can lead to hard to debug errors, so I would simply revert these changes.
There was a problem hiding this comment.
@melix I didi it, because Idea every time tell me, that is configureEach better than all:
There was a problem hiding this comment.
Don't always trust your IDE I guess ;)
| @@ -5,7 +5,7 @@ plugins { | |||
| } | |||
|
|
|||
| tasks.named("htmlSanityCheck") { | |||
| sourceDir = new File("${rootProject.buildDir}/docs/guide/") | |||
| sourceDir = file("${rootProject.layout.buildDirectory.asFile.get()}/docs/guide/") | |||
There was a problem hiding this comment.
❌ This is a mix of file and layout.
| sourceDir = file("${rootProject.layout.buildDirectory.asFile.get()}/docs/guide/") | |
| sourceDir = rootProject.layout.buildDirectory.dir("docs/guide").get().asFile |
core/build.gradle
Outdated
| @@ -31,7 +31,7 @@ spotless { | |||
| } | |||
|
|
|||
| def versionInfo = tasks.register("micronautVersionInfo", WriteProperties) { | |||
| outputFile = "${buildDir}/resources/version/micronaut-version.properties" | |||
| destinationFile = file("${layout.buildDirectory.asFile.get()}/resources/version/micronaut-version.properties") | |||
There was a problem hiding this comment.
❌ destinationFile is a proper RegularFileProperty
| destinationFile = file("${layout.buildDirectory.asFile.get()}/resources/version/micronaut-version.properties") | |
| destinationFile = layout.buildDirectory.file("resources/version/micronaut-version.properties") |
| @@ -48,7 +48,7 @@ graalvmNative { | |||
| enabled = true | |||
| } | |||
| binaries { | |||
| all { | |||
| configureEach { | |||
There was a problem hiding this comment.
Same here, configureEach doesn't make sense since it's a model element, so it will register tasks in any case. This will never be lazy.
sdelamo
added
the
relates-to: build
|
I reverted |
No description provided.