Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sanity checks #711

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Add sanity checks #711

merged 2 commits into from
Jul 18, 2024

Conversation

melix
Copy link
Contributor

@melix melix commented Jul 18, 2024

No description provided.

melix added 2 commits July 18, 2024 15:58
@melix
More robust version parsing
08a28c7 
Based on what we've seen in real cases, e.g versions which start
with a dot.
@melix
Make sure versions are starting with a digit
cdb4868
@melix melix added this to the 7.2.1 milestone Jul 18, 2024
@melix melix requested a review from alvarosanchez July 18, 2024 14:02
@melix melix self-assigned this Jul 18, 2024
@melix melix merged commit c06c787 into master Jul 18, 2024
3 checks passed
@melix melix deleted the cc/sanity-checks branch July 18, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarosanchez alvarosanchez alvarosanchez approved these changes

Assignees

@melix melix

Labels
None yet
Projects
None yet
Milestone
7.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@melix @alvarosanchez